| title: | Re PATCH xt TCPMSS SYN packets are allowe |
|
On Tue, January 19, 2010 09:17, William Allen Simpson wrote:
Simon Arlott wrote:
The check for data only needs to apply where the packet length
could be increased by adding the MSS option. (The MSS option
itself applies to the senders maximum receive size which is
not relevant to any data in its own packet.)
This moves the check for (header size != packet size) to after
attempting to modify an existing MSS option. Another check is
needed before looking through the header to ensure it doesnt
claim to be larger than the packet size.
2) There certainly *can* be data on SYN. That code is already in
2.6.33....
I could change the comment too, but the same logic applies when
there is data and no MSS option - the packet cant be increased
in size if it would then exceed 576 bytes and/or the destination
MTU.
If its possible to know that the packet can have an additional
option added without exceeding MTU then this could be changed.
The data part would need to be moved to make space at the end of
the header.
--
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at rel="nofollow" vger.kernel.org/majordomo-info.html vger.kernel.org/majordomo-info.html
|
